fix: clear remaining ruff baseline errors on main#223
Merged
Conversation
Multi-line summary lacked a blank line before the description body. Collapse to a single-line summary, then explanatory paragraph. Flagged by pre-commit.ci on PR #222 — not specific to that PR, but the same lint check would block every future PR until cleared.
for more information, see https://pre-commit.ci
After pre-commit.ci's autofix commit (af9fae7) cleared the bulk of the baseline, 7 unfixable errors remained — same set of violations that PR #222 also carries. Apply the same fix here so main is ruff-clean independently of PR #222's merge: - gget_g2p.py: collapse the multi-line docstring summary into a single line + paragraph break (ruff D205). - main.py: add # noqa: E402 to the 6 module-function imports (g2p, ref, search, seq, setup, virus). main.py has executable code (dt_string assignment) above the import block, so every later import needs the noqa. Drops the now-redundant "# Module functions" comment that was splitting one alphabetical list into two. After this commit, `ruff check gget/` reports zero errors, so new PRs no longer inherit a ruff failure on pre-commit.ci.
lauraluebbert
changed the title
The exclude block listed tests/pytest_results_py.*\.txt — the per- Python report filename that was used before commit 244d4d2 consolidated CI to a single tests/pytest_results.txt. The new filename doesn't match the old pattern, so pre-commit was processing the autogenerated report and trimming its trailing whitespace on every run (see autofix commit af9fae7 in this PR). Widen the pattern to tests/pytest_results.*\.txt so it covers both the current canonical name and any future variant. Pre-existing whitespace changes to tests/pytest_results.txt are left as-is — CI rewrites the file on every scheduled run anyway, so the diff is ephemeral.
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 56.41% 56.04% -0.38%
==========================================
Files 29 29
Lines 9228 9229 +1
==========================================
- Hits 5206 5172 -34
- Misses 4022 4057 +35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lauraluebbert
added a commit
that referenced
this pull request
Jun 22, 2026
…t main bot commits # Conflicts: # .github/badges/tests.json # tests/pytest_results.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After pre-commit.ci's autofix cleared the bulk of the ruff baseline, 7 unfixable errors remained — the same set PR #222 also addresses. This PR applies the fixes on main so the baseline is at zero independent of PR #222's merge order.
After this PR,
ruff check gget/reports 0 errors.What was wrong
D205ingget/gget_g2p.py:22— multi-line docstring summary without the required blank line before the description body.E402ingget/main.py:33,42–46— module-level imports forg2p,ref,search,seq,setup,viruswithout the# noqa: E402comment that the surrounding imports carry.main.pyhas executable code (dt_string = datetime.now()) above the import block, so every later import needs the noqa.What changed
gget/gget_g2p.py: collapsed the multi-line summary into one line + paragraph break.gget/main.py: added# noqa: E402to the 6 imports; dropped the now-stale# Module functionscomment that was splitting one alphabetical list into two.